Tag images with 'latest' and release tags #226
Conversation
pierDipi
changed the title
Signed-off-by: Pierangelo Di Pilato <[email protected]>
| @@ -181,7 +181,9 @@ func Generate(cfg Config) error { | |||
| Nudges: append(cfg.Nudges, cfg.NudgesFunc(c.ReleaseBuildConfiguration, ib)...), | |||
| Pipeline: pipeline, | |||
| AdditionalTektonCELExpression: cfg.AdditionalTektonCELExpressionFunc(c.ReleaseBuildConfiguration, ib), | |||
| Tags: []string{"latest"}, | |||
There was a problem hiding this comment.
I probably miss something, but just to be sure here: as we use the same pipeline for on-push and on-pr, wouldn't we tag images from PRs also with latest?
There was a problem hiding this comment.
no, the parameter is only added for push pipeline
There was a problem hiding this comment.
{{{- if eq .Event "push" }}}
- name: additional-tags
value: [{{{ range $tag := .Tags }}} {{{ $tag }}}, {{{ end }}}]
{{{- end }}}
There was a problem hiding this comment.
Example:
spec:
params:
- name: dockerfile
value: olm-catalog/serverless-operator/index/Dockerfile
- name: git-url
value: '{{source_url}}'
- name: image-expires-after
value: 5d
- name: output-image
value: quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-release-134/serverless-index:on-pr-{{revision}}
- name: revision
value: '{{revision}}' params:
- name: dockerfile
value: olm-catalog/serverless-operator/index/Dockerfile
- name: git-url
value: '{{source_url}}'
- name: output-image
value: quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-release-134/serverless-index:{{revision}}
- name: revision
value: '{{revision}}'
- name: additional-tags
value: [ latest, ]There was a problem hiding this comment.
we're injecting parameters for the pipeline run and we have one pipeline run per event (push and PR separate)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e9f6e14
into
openshift-knative:main
This will help with generating the CSV file with the "latest" image SHAs
Here is how it will be used openshift-knative/serverless-operator#2826